Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve amp plugin compat #140

Merged
merged 13 commits into from
Jan 29, 2020
Merged

Improve amp plugin compat #140

merged 13 commits into from
Jan 29, 2020

Conversation

swissspidy
Copy link
Collaborator

See #3

@swissspidy swissspidy marked this pull request as ready for review January 28, 2020 14:37
@swissspidy swissspidy mentioned this pull request Jan 28, 2020
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller tweaks here.

includes/Story_Post_Type.php Outdated Show resolved Hide resolved
includes/Story_Post_Type.php Outdated Show resolved Hide resolved
includes/templates/single-web-story.php Outdated Show resolved Hide resolved
includes/templates/single-web-story.php Outdated Show resolved Hide resolved
includes/Story_Post_Type.php Outdated Show resolved Hide resolved
Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacedmonkey added a quite thorough review 👍 LGTM!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@spacedmonkey
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spacedmonkey spacedmonkey merged commit da1ded5 into master Jan 29, 2020
@spacedmonkey spacedmonkey deleted the improve/amp-plugin-compat branch January 29, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants